search

collective / collective.cover

A sane, working, editor-friendly way of creating front pages and other composite pages. Working now, for mere mortals.
48 stars 55 forks source link

Remove carousel tile from the package core #485

Open hvelarde opened 9 years ago

hvelarde commented 9 years ago

Lately we have had some discussions about many things on the carousel tile and some pull requests have been proposed to offer an alternative solution

There are many solutions for carousels and everybody seems to have their own opinion on which one is the best.

So… should we just spin off the code of the carousel tile out of the core of this package to make it easier to maintain and leave people to choose whatever JS plug-in they want to use?

djowett commented 9 years ago

I think yes... but smoothing the migration could do with some bright ideas

rodfersou commented 9 years ago

I agree with the idea too

fredvd commented 9 years ago

Can't disagree here, suggested it in #442 :-)

espenmn commented 9 years ago

Yes. I think: as little as possible in the core,

(and also, if it should be of any interest, I started work with tiles for collective.plonetruegallery https://pypi.python.org/pypi/collective.ptg.tile/0.1b1 (worked when I made it, but has never been used on any sites)

hvelarde commented 9 years ago

@espenmn feel free to document that on the README file

djowett commented 9 years ago

Just to log (for those who don't already know) that https://github.com/collective/covertile.cycle2 is a new carousel tile based on the Cycle2 framework. It could do with some review & feedback from any interested party before it's first release

hvelarde commented 9 years ago

@djowett we are going to start using it tomorrow; we will let you know.

djowett commented 9 years ago

Correct me if I'm wrong, but this is not question any more...

hvelarde commented 9 years ago

no, I will open a branch later today to address this issue and will move the code of the Galleria carousel to the new package.