search

collective / collective.cover

A sane, working, editor-friendly way of creating front pages and other composite pages. Working now, for mere mortals.
48 stars 55 forks source link

Fix PicklingError when editing basic tile that contains an image #908

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

Using applyChanges as is done in plone.app.tiles fixes the problem. See:

https://github.com/plone/plone.app.tiles/blob/b87450b0c7eff38b224f3306e0bbfc20d3a48e12/plone/app/tiles/browser/edit.py#L113-L119

Fixes #907

codecov-commenter commented 2 years ago

Codecov Report

Merging #908 (8e3d5b5) into master (98e74c2) will decrease coverage by 0.02%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   82.29%   82.27%   -0.03%     
==========================================
  Files          45       45              
  Lines        2807     2809       +2     
==========================================
+ Hits         2310     2311       +1     
- Misses        497      498       +1
Impacted Files Coverage Δ
src/collective/cover/tiles/edit.py 51.56% <16.66%> (-0.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98e74c2...8e3d5b5. Read the comment docs.

wesleybl commented 2 years ago

@frapell @pbauer @cleberjsantos can you please take a look here?