search

collective / collective.cover

A sane, working, editor-friendly way of creating front pages and other composite pages. Working now, for mere mortals.
48 stars 55 forks source link

Remove unused customization from renderBase method in plone view #913

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

In fact, in Plone 5, the plone view doesn't even have a renderBase method anymore. See:

https://github.com/plone/Products.CMFPlone/blob/5.2.x/Products/CMFPlone/browser/ploneview.py

This customization was done to fix a problem in Layout Javascript:

https://github.com/collective/collective.cover/commit/9c7ceccfe1a9f0fb8015b27e9c55071ec3cc1ab2

However, today the layout setup is working without it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #913 (645ea08) into master (daa78d9) will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   85.27%   85.31%   +0.03%     
==========================================
  Files          46       45       -1     
  Lines        2825     2819       -6     
==========================================
- Hits         2409     2405       -4     
+ Misses        416      414       -2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daa78d9...645ea08. Read the comment docs.