search

collective / collective.cover

A sane, working, editor-friendly way of creating front pages and other composite pages. Working now, for mere mortals.
48 stars 55 forks source link

Fix test tile sorting #927

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

In commit

https://github.com/collective/collective.cover/commit/c403cbd8dbdd87d2b1b48aa27ee4e16e92a3a3d2

the function onStop of ComposeView, has been removed to fix the drag and drop of content from one tile to another. However, it is still needed to save the position of a content, when drag and drop occurs on the same tile, for sorting within the tile.But we do a test, to make sure it will only do something, if the drag and drop is done on the same tile. Otherwise, an error occurs when moving content from one tile to another.

Fixes #925

codecov-commenter commented 2 years ago

Codecov Report

Merging #927 (d3a9a75) into master (adcdca1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #927   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          45       45           
  Lines        2835     2835           
=======================================
  Hits         2628     2628           
  Misses        207      207

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adcdca1...d3a9a75. Read the comment docs.

wesleybl commented 2 years ago

Can someone please take a look here?

@hvelarde @rodfersou @cleberjsantos @mauritsvanrees