search

collective / collective.cover

A sane, working, editor-friendly way of creating front pages and other composite pages. Working now, for mere mortals.
48 stars 55 forks source link

Fix error when clearing content chooser input #944

Closed wesleybl closed 1 year ago

wesleybl commented 1 year ago

When we cleared the filter, the contents of the previous filter and the amount of items found were still displayed.

This was due to a Javascript error. The variable portal_url was not defined inside the function that is called when clicking on the clear button. Then we use this.portal_url, to use the class variable. For this to be considered the class, it was necessary to use arrow functions.

Fixes #942

codecov-commenter commented 1 year ago

Codecov Report

Merging #944 (c02dc8f) into master (7faaa51) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          49       49           
  Lines        2913     2913           
=======================================
  Hits         2705     2705           
  Misses        208      208

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7faaa51...c02dc8f. Read the comment docs.