search

collective / collective.dancing

New repository for singing & dancing
2 stars 10 forks source link

Newsletters in queue with uid #10

Closed cekk closed 10 years ago

cekk commented 10 years ago

Hi, i created this branch to change the way of newsletters are put in queue jobs. If we store their path, if someone move/rename/delete the content before the dispatch, the newsletter stays in a broken state and the system doesn't give any information about this problem. Another problem is that with the path, if the content is moved/renamed, it cannot be found with a restrictedTraverse.

With the UID we can handle the case when the content is renamed/removed. I have also handled the case when the content is deleted, and the info is given to the user and write in the log.

I updated translations and tests.

dnouri commented 10 years ago

Looks good to me! (Turns out I can't merge pull requests.)

cekk commented 10 years ago

@dnouri I think because you are not in the collective group. Last commits are made by @saily and @kiorky : what do you think about this pullrequest guys?

Can i merget it? I've fixed also two dependencies to make travis run

saily commented 10 years ago

Thanks, i'll merge that one.