Fix #23: Add compatibility layer for Plone 4.0

collective / collective.dancing

New repository for singing & dancing

2 stars 10 forks source link

Fix #23: Add compatibility layer for Plone 4.0 #26

Closed mck9 closed 6 years ago

frisi commented 9 years ago

thanks @mck9

this looks good to me. according to @saily's commit (https://github.com/collective/collective.dancing/commit/d82ed54f628bd86f92f6cbf411a189f06986a67d) we still support plone 4.0 and have tests for it. i wonder how tests did pass w/o this conditional import. @saily can you please tell me if we required additional packages in the buildout that could handle this as well or if we should merge this change?

saily commented 9 years ago

@frisi i have no idea and no time to look into this.

frisi commented 9 years ago

as archetypes.referencebrowserwidget does it the same way i'd merge this. maybe @mck9 can look up why tests have been passing for plone4.0 w/o this change (maybe we can find and fix some test-problems here)

frisi commented 6 years ago

cleaning up the tracker - support for plone >4.3 has been dropped in https://github.com/collective/collective.dancing/commit/d65d0dfc40b256736202c4e22f8b800581712dce