search

collective / collective.documentviewer

https://pypi.org/project/collective.documentviewer
21 stars 22 forks source link

565 dw replace docsplit #79

Closed alphaomega325 closed 4 years ago

alphaomega325 commented 4 years ago

I made many changed and modifications. The most obvious being that I depcreciated docsplit, and instead called the various packages directly from convert.py. I also cleaned up on the travis files and fixed the various issues of the master branch. All the while trying to maximize the amount of backwards compatibility in terms of the conversion process and the output of said conversion process. I hope that it is up to snuff and that we can soon merge it with the main branch.

tkimnguyen commented 4 years ago

thanks @alphaomega325 ! This is much appreciated. @vangheem isn't active anymore. I can't promise when I can review/try this. It would have been easier to break this out into pieces so that we could look at atomic changes, e.g. docsplit being one, cleanup of other parts being separate PRs

pbauer commented 4 years ago

I gave this branch a test-drive today (with Plone 5.2.1 on Python 3.8) and found that it works fine 👍

ale-rt commented 4 years ago

I made a PR myself to hopefully clarify some things and maybe clean up. Anyway the fixes are totally irrelevant for the code functionality. I confirm the work you did is awesome :) https://github.com/collective/collective.documentviewer/pull/80/files

alphaomega325 commented 4 years ago

Merged @ale-rt improvements into this branch.

ale-rt commented 4 years ago

@tkimnguyen, after reviewing the code and getting the feedback from @pbauer, I am very much in favour of merging this brilliant PR. What do you think?

After this is merged it would be great if a release of a 6.0.0 version would happen on PyPI.

mauritsvanrees commented 4 years ago

This PR was merged early February, and no changes on master since then. Well, I added an entry in docs/HISTORY.txt, and bumped the version to 6.0.0.

Can we have a new release?

mauritsvanrees commented 4 years ago

I have released 6.0.0. Many thanks to @alphaomega325 (and others who contributed other fixes)!