collective / collective.embeddedpage

collective.embeddedpage allows to embed remote HTML pages in Plone.
0 stars 4 forks source link

Title is showen doubled when add embeddedpage #42

Closed humboldtuni closed 2 years ago

humboldtuni commented 2 years ago

Please take out the 'Title' in schema, because there is already a 'plone.namefromtitle' behavior

tisto commented 2 years ago

The EmbeddedPage content type indeed defines title and description twice. Once in the interface/schema:

https://github.com/collective/collective.embeddedpage/blob/main/src/collective/embeddedpage/interfaces.py#L19

And via the Dublin core behavior:

https://github.com/collective/collective.embeddedpage/blob/main/src/collective/embeddedpage/profiles/default/types/EmbeddedPage.xml#L41

tisto commented 2 years ago

PR with the fix: https://github.com/collective/collective.embeddedpage/pull/43

tisto commented 2 years ago

@humboldtuni released with https://pypi.org/project/collective.embeddedpage/3.0.1/