collective / collective.embeddedpage

collective.embeddedpage allows to embed remote HTML pages in Plone.
0 stars 4 forks source link

Requests to URLs that do not respond run on forever #49

Closed wolbernd closed 3 months ago

wolbernd commented 4 months ago

When calling an URL via an embeddedPage that does accept a connection but never sends a reply, this addon will not run into a timeout and will wait forever for a reply. On high traffic sites this can lead to resource exhaustion on the Plone servers as there is a limit to the open connections an instance can have open.

Steps to reproduce:

What happens:

What should happen

The request to the external URL should time out after a certain time and an error message should be shown.

wolbernd commented 4 months ago

I checked the code and it should be relatively easy to implement a timeout in the request. I will provide a PR either today or tomorrow.