collective / collective.exportimport

Export and import content and other data from and to Plone
GNU General Public License v2.0
15 stars 15 forks source link

Better Plone 4 / Python 2 compatibility #233

Closed thet closed 4 months ago

thet commented 4 months ago

When I‌ tried to install this package in Plone 4 it took me some time to get the versions straight. It would have saved me some time if I had read the Plone 4 install section in the README, but I didn't and it is well hidden.

I think having an easy installation experience in Plone 4 with Python 2 is quite important for this package as this is probably a frequent use case.

This PR should fix that out of the box and improve the README a bit, as of the time of this writing. There is a good chance that it will break again, however, for now it does work fine.

/cc @canepan

thet commented 4 months ago

I‌ take that as a go :D Time to merge, I've tested in in Plone 4 and Plone 6 and it works just fine.

pbauer commented 4 months ago

@thet weird, since this merge this packages main page does not render anymore in github, same for forks. Also maybe related: @flipmcf ran into this issue during installation:

mr.developer: Updated 'collective.exportimport' with git.
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.9/threading.py", line 892, in run
    self._target(*self._args, **self._kwargs)
  File "/home/mcfaddenm/repos/plone5.2_clean/rfasite/rfasite/eggs/mr.developer-2.0.1-py3.9.egg/mr/developer/common.py", line 181, in worker
    for lvl, msg in wc._output:
ValueError: too many values to unpack (expected 2)
pbauer commented 4 months ago

The issue has gone away :)

thet commented 4 months ago

Wow, great :) Both issues?

@flipmcf issue looks like if you got a Python 2 incompatible package, actually the kind of problem my PRs here should have fixed. But there will be similar problem popping up as soon as another dependency is released as Python 3 only package where we do not have any requirement constraints.

The other issue - I updated the README - maybe I created an .rst error.