search

collective / collective.jsonmigrator

JSON based migrations for Plone
GNU General Public License v2.0
8 stars 21 forks source link

Fix PartialCommit, fix module references, link to sub-pages from the index, and tidying #4

Closed jean closed 9 years ago

jean commented 10 years ago

At the moment https://collectivejsonmigrator.readthedocs.org/ provides no way to navigate to sub-pages, so remove hidden directive from TOC. Grammar & spelling fixes. Move PartialCommit from blueprints to its own module (other blueprint steps still need to be done).

garbas commented 10 years ago

@jean tnx for the pull request i'm busy currently at #beerandwine sprint in munich but i'll somehow find the time to merge your work. just need to ask all involved first

@jone you maybe have time to look? it looks ok to me, but i see you were using c.jsonmigrator 3 months ago so it might be breaking your stuff in some way

jone commented 10 years ago

:+1: looks good! We usually don't use PartialCommit (possibly because it was not registered) - we use the savepoint section.. I currently have no migration ready where I could test it, but I think it is okay :wink:

jean commented 10 years ago

We usually don't use PartialCommit (possibly because it was not registered) - we use the savepoint section..

Ah. I wasn't aware of savepoint. I was looking only in jsonmigrator. Do we need PartialCommit at all? Maybe we should just refer users to more blueprints provided by collective.transmogrifier.

jean . .. .... //\oo///\

thet commented 9 years ago

defintely an improvement regarding docs. and code needs some refactoring, so i'm going to merge this.