collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

revised explanation text #25

Closed rileydog closed 7 years ago

gforcada commented 7 years ago

@rileydog would you mind rebasing your changes? Unfortunately your merge request was not merged at that time and some other changes got in between.

hvelarde commented 7 years ago

also, I'm not full in favor of merging this; the grammar may be enhanced but I don't think it explains better what the package does.

we need more opinions.

rileydog commented 7 years ago

Hi, @gforcada and @hvelarde Not sure what action there is for me to do. I'm sorry, but I'm a complete nubbie on this branching and stuff. I worked on this during the sprint at Boston. If you folks don't think the changes are good, I trust your judgment. Can you just delete them? (see I don't understand how this works). If I can do something to help, please let me know.

hvelarde commented 7 years ago

don't worry; thanks anyway!