collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

missing ++resource++collective.lazysizes/ls.respimg.min.js after upgrade #32

Closed agitator closed 6 years ago

agitator commented 7 years ago

when upgrading from 2.0.5rc1 to 3.0.0 I get this error when I try to recompile the productions bundle by enable/disable dev mode

Sorry, the requested resource does not exist.<p>Check the URL and try again.</p><p><b>Resource:</b> http://localhost:11681/Plone/++resource++collective.lazysizes/ls.respimg.min.js</p>

is this a leftover? should it be cleaned by an upgrade step - i applied all available steps for the addon

hvelarde commented 7 years ago

I suposse you are using Plone 5, right? can you help me debugging the upgrade step?

https://github.com/collective/collective.lazysizes/blob/master/src/collective/lazysizes/upgrades/v7/__init__.py#L12-L19

check this thread:

https://community.plone.org/t/updating-static-files-with-legacy-bundle-in-plone-5/3579?u=hvelarde

agitator commented 7 years ago

yes Plone 5, I'll try to look into it the next days

hvelarde commented 7 years ago

FYI, @thet is currently fixing the JS mess for Plone 5 in #36.

hvelarde commented 6 years ago

@agitator can you confirm if this was fixed?

agitator commented 6 years ago

@hvelarde upgraded to 4.0.1 and had no problems so far, but don't have any "older" instance to test

2017-12-07 08:48:57 INFO collective.lazysizes JavaScripts resources were cooked
2017-12-07 08:48:57 INFO Products.GenericSetup.tool Profile collective.lazysizes:default upgraded to version ('9',).
hvelarde commented 6 years ago

ok, closing this one then.