products breaks embedded videos

rafaeltcc commented 7 years ago

Hi,

I have some videos embedded in my page. I add them copying the embedded code as provided by facebook. I just adjust some styles properties to make them responsive.

example page: https://inverta.org/jornal/cobertura-da-greve

When I activate collective.lazysizes images work well, but my frame appears empty. Somehow the product is making those contents not to load at all.

Thanks,

Rafael

hvelarde commented 7 years ago

you have to provide more details; AFAIK Facebook videos are working on CartaCapital with lazysizes installed.

anyway, you can mark that video with a class and then configure the package to ignore that class all over the place.

rafaeltcc commented 7 years ago

Hi,

Steps to reproduce.

1 - Install collective.lazysizes in plain Plone 5.0.7

2 - Add an embedded facebook video, with same css for responsiveness (this does not matter, though), for example:

3 - Instead of it being correctly rendered I get as output when viewing the source of the page viewed in my browser

I don't know a lot about lazysizes, but, if my data-src is not replaced it seems hat something in the javascript has not worked, correct?

I now found that this problem is browser dependent. In firefox desktop, the videos are not rendered, but the images are. And in Chrome desktop, all the content seems to be correctly rendered.

How can I help to debug it further? I first thought this was a conflict with mosaic, but in plain pages I get this error.

Hector, as you are also a devolper of sc.embedder, is it tested together with colelctive.lazysizes? I might give it a try

hvelarde commented 7 years ago

I'm busy right now; maybe I could help you by the end of the week.

hvelarde commented 5 years ago

do you mind to upgrade this plugin in your site and test again?

collective / collective.lazysizes

products breaks embedded videos #33