search

collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

Add configlet option to enable lazy loading for authenticated users #35

Closed hvelarde closed 7 years ago

hvelarde commented 7 years ago

closes #34

hvelarde commented 7 years ago

@gforcada I'm don't know how to make the test work, can you help me here?

I'll release this after the new v4.0.0 of lazysizes is out.

gforcada commented 7 years ago

@hvelarde the error message is quite clear:

    ConfigurationError: ('Invalid value for', 'package', 'ImportError: Module collective.lazysizes.upgrades has no global v8')

On a zcml you define a v8 package that does not exist.

hvelarde commented 7 years ago

@gforcada any news on this?

gforcada commented 7 years ago

@hvelarde the code looks fine, but I have no idea why is it failing on travis, you are the expert on this code base :-)

hvelarde commented 7 years ago

found the issue and added some comments on the code you didn't understand.

hvelarde commented 7 years ago

integration with Travis CI is failing right now; I'm going to wait before merging this.

thet commented 7 years ago

@hvelarde looks very good to me, except the test setup where I wouldn't use browser tests and make it independent from the plone version.

Another minor thing are the translation strings - you are not using explicit message ids but the original english text as implicit message id. This will break as soon as you want to fix a type in the original text. But I'd change that in a separate PR - i can do that.