collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

require plone.app.registry >=1.5. Refs #42 #43

Closed erral closed 6 years ago

erral commented 6 years ago

@hvelarde can you check this?

I needed not only to require plone.app.registry >= 1.5 on setup.py but set also on the testing buildout because Plone 4.3.x's requirement is plone.app.registry = 1.2.5. To get that I had to split the testing buildout file into multiple ones and change the testing config on .travis.yml. Please if this configuration is or you'd rather do it in another way.

hvelarde commented 6 years ago

in fact is simpler than that; all you need to do is:

...
env:
- PLONE_VERSION=4.3 VERSIONS=plone.app.registry=1.5
- PLONE_VERSION=5.0
- PLONE_VERSION=5.1
...
install:
...
- bin/buildout $VERSIONS annotate
- bin/buildout $VERSIONS
...

take a look at how this works on collective.cover.

erral commented 6 years ago

Thanks, it's in fact much easier...

hvelarde commented 6 years ago

thanks! I'm going to update lazysizes to 4.0.1 later and then make a new release:

https://github.com/aFarkas/lazysizes/releases/tag/4.0.1