search

collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

Upgrade from 1.5.0a1 to 3.1 fails #46

Closed hvelarde closed 6 years ago

hvelarde commented 6 years ago

this happens in Plone 4.3.3:

2017-12-01T00:23:09 ERROR Zope.SiteErrorLog 1512094989.610.449691169693 http://www.example.org/portal_quickinstaller/prefs_reinstallProducts
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFCore.FSPythonScript, line 127, in __call__
  Module Shared.DC.Scripts.Bindings, line 322, in __call__
  Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
  Module Products.PythonScripts.PythonScript, line 344, in _exec
  Module script, line 11, in prefs_reinstallProducts
   - <FSPythonScript at /Plone/prefs_reinstallProducts used for /Plone/portal_quickinstaller>
   - Line 11
  Module Products.CMFPlone.QuickInstallerTool, line 101, in upgradeProduct
  Module Products.GenericSetup.upgrade, line 140, in doStep
  Module collective.lazysizes.upgrades.v5, line 19, in use_amd_version
  Module Products.ResourceRegistries.tools.BaseRegistry, line 948, in renameResource
  Module Products.ResourceRegistries.tools.BaseRegistry, line 428, in validateId
ValueError: Duplicate id ++resource++collective.lazysizes/lazysizes-umd.min.js
hvelarde commented 6 years ago

@rodfersou any hints?

hvelarde commented 6 years ago

the problem is the following: 1.5.0a1 profile version is 3; in the upgrade step from 3 to 4 we registered the whole jsregistry.xml and it's completely modified leading to a registration of the UMD version and leaving the old non-UMD version registered also.

this breaks the package and needs to be fixed.