search

collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.
https://pypi.org/project/collective.lazysizes
6 stars 2 forks source link

Deprecate resource registries #57

Closed hvelarde closed 6 years ago

hvelarde commented 6 years ago

@thet thanks for such in depth analysis; I will clarify some stuff for you:

yes, we are going to implement a hash on the generated resources on a separate pull request just after merging this; we've done it in the past, for instance, here:

https://github.com/plonegovbr/brasil.gov.temas/blob/2.0b2/webpack/webpack.config.js#L17

that completely eliminates the need for cooking resources and we have extensively tested in the previous months while working on the new Plone portal for the Brazilian Government; it works just fine!

the generated resources are not included in VCS because there's no need to do so; they are generated by our buildout recipe at development time, and are updated and uploaded to the egg when we make a new release (this process is currently manual, but a zest.releaser plugin could be build).

thet commented 6 years ago

Your webpack approach is really quite interesting.

hvelarde commented 6 years ago

thank you! we have been experimenting, developing, testing and enhancing it over the past year; now we're going to push it (with the viewlet) on all of our add-on; the fun part starts after that.