Why is 4.1.6 not a 5.0 release?

collective / collective.lazysizes

Integration of lazysizes, a lightweight lazy loader, into Plone.

https://pypi.org/project/collective.lazysizes

6 stars 2 forks source link

Why is 4.1.6 not a 5.0 release? #80

Closed agitator closed 5 years ago

agitator commented 5 years ago

With theses changes:

Update lazysizes to v4.1.6. [hvelarde]
Add support for Plone 5.2 and Python 3. [hvelarde]
Drop explicit support for Plone 5.0. [hvelarde]
Code clean up. [hvelarde]

shouldn't it be a 5.x release?

hvelarde commented 5 years ago

IMO, Plone 5.0 has many issues and it was difficult to test against it. anyway, this release should work with it, just test it.

agitator commented 5 years ago

I share your opinion about Plone 5, question was just about the version increase. Dropping support for a major release would imho be a 5.0 release of c.lazysizes - https://semver.org ;-)

hvelarde commented 5 years ago

you are right, but versioning in this package follows the one on lazysizes.

as you can see in the changelog I was saying "drop explicit support" that means that it could still work, but we're no longer testing against it.

just upgrade your Plone ;-)

agitator commented 5 years ago

ah now I got you ;-)