Python 3 compatibility + test fixtures

collective / collective.logbook

Advanced exception logging for Plone

5 stars 2 forks source link

Python 3 compatibility + test fixtures #21

Closed ramonski closed 4 years ago

ramonski commented 4 years ago

Description

This PR makes the codebase compatible with Python3 and fixes TravisCI

ramonski commented 4 years ago

Hi @rafaelbco, I fixed the tests and made the codebase compatible with Python 2/3. Could you test if everything works for you, then I'll do the 1.0.0 release. Also feel free to do code changes in this branch.

ramonski commented 4 years ago

Thanks @rafaelbco for the tweak which I've just merged.

Regarding the single vs. double quotes I usually use double quotes. However, I'm fine when you change it to single quotes to be consistent in the codebase, so please go ahead.

I'm going to release then after your PR.