search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Add deprecation warnings on 1.x branch? #131

Closed hvelarde closed 7 years ago

hvelarde commented 9 years ago

We are removing a lot of code from this package for version 2.0.

Are those methods used by somebody?

Do we need to add deprecation warnings on those methods on 1.x branch?

hvelarde commented 9 years ago

@idgserpro what do you think?

idgserpro commented 9 years ago

2.0 is already broken for some packages that started using collective.nitf in 2013 and have some customizations, specially the commit https://github.com/collective/collective.nitf/commit/474fb08ef13f2d07f1d279682552dcdf36333139. I think it would be nice but don't know if it's worth the hassle since it's going to be a major release. I think it depends on your agenda, we can't take this issue right now.

hvelarde commented 9 years ago

I can't neither; but if it's broken at least someone needs to report where is broken so we can prepare a transitional release for the 1.x branch listing all deprecations.

thanks anyway!

idgserpro commented 9 years ago

Don't know if I'm being unfair saying this package is broken in 2.0, but we used to customize some templates using grok, but the classes don't exist anymore. For example:

from collective.nitf.browser import Display_Macros as NitfCustomDisplayMacros

and 

from collective.nitf.browser import Nitf_Galleria as NitfCustomGalleria

when you still had browser.py instead of a browser folder now in 2.0. This is what we have found so far.

hvelarde commented 9 years ago

@idgserpro read the changelog; we are replacing Galleria with Cycle2 and we are cleaning up the whole thing: templates, views, etc.

follow #130 and don't use five.grok anymore.

hvelarde commented 7 years ago

superseded by #199