search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Remove portlet code from package #132

Closed hvelarde closed 6 years ago

hvelarde commented 9 years ago

AFAIK, as the portlet inlcuded in the package is not used in any of our projects, so it would be a good idea to remove it from it.

We will need an upgrade step that walks through the site and removes any assignment referencing it.

cleberjsantos commented 7 years ago

I don't think that should to remove, what do you think of change the portlet to stay like here https://github.com/collective/collective.nitf/issues/196#issuecomment-282804716?

hvelarde commented 7 years ago

the fact is I think nobody is using this portlet and I don't want to have to maintain it; I'll ask in the plonegovbr forum.

cleberjsantos commented 7 years ago

Understand.

idgserpro commented 7 years ago

the fact is I think nobody is using this portlet and I don't want to have to maintain it

That's a really hard decision to make: how do we measure that nobody is really using this feature? How do we avoid doing things like it was done in https://github.com/plone/Products.CMFPlone/issues/668#issuecomment-122211416? We do agree it's not the same situation in orders of magnitude (one is at the core and this one is a specific feature in an add-on), but we still think that it's hard trying to measure it.

Anyways, do as you see fit since you're much more active than us on collective.nitf. From a 1.0x to 2.0x version of a package lots of modification are expected, just document them with a WARNING in CHANGEs.rst pointing to the last commit (or the link you provided on the email list, https://github.com/collective/collective.nitf/tree/1.0b10/src/collective/nitf/portlets) that implemented this feature so people that really need this feature can add it in a policy package.

hvelarde commented 7 years ago

@idgserpro we're talking about very different thing; that portlet was created for a very specific use case in early 2012; besides that customer, I've never seen anybody using it.

for me makes absolutely no sense to maintain that code there; that's an example of custom code that must live in project packages.

we're going to provide an upgrade step just to be sure the portlet is removed from the site in case it's being used and, of course, a line on the changelog.