collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

fix attribute error on upgrade step #140

Closed winstonf88 closed 8 years ago

winstonf88 commented 8 years ago

closes #139

winstonf88 commented 8 years ago

@rodfersou this still has to go through some tests.

hvelarde commented 8 years ago

@winstonf88 could you please add some code comments explaining the change?

also, please check if that change must be applied to master.

rodfersou commented 8 years ago

@winstonf88 #plonegovbr uses version 1.x of c.nitf, please do your changes on a branch derived from 1.x branch, not on master.

Master branch is for 2.x version.

idgserpro commented 8 years ago

@rodfersou isn't this fix necessary in version 2.0 as well? What if in the future someone updates from 1.0 to 2.0?

hvelarde commented 8 years ago

@rodfersou that upgrade step is included in master also; can you restore the branch?