search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Don't show image on tile collection if image attribute is None #179

Closed rodfersou closed 7 years ago

rodfersou commented 7 years ago

related to https://github.com/collective/collective.cover/pull/681/files

closes https://github.com/collective/collective.nitf/issues/178

hvelarde commented 7 years ago

@rodfersou well, that's pretty weird: I was expecting a failure the same error in your first try: AttributeError: 'NoneType' object has no attribute 'restrictedTraverse', but instead you got TypeError: 'NotImplementedType' object is not callable.

that makes no sense to me.

rodfersou commented 7 years ago

@hvelarde the exception you expect is silenced in this piece of code: https://github.com/plone/plone.tiles/blob/master/plone/tiles/esi.py#L67-L70

That's why we get the TypeError: NotImplementedType' object is not callable exception.