search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Handle corner case when upgrade step for 1008 found a collection with no query defined #187

Closed hvelarde closed 7 years ago

hvelarde commented 7 years ago

closes #186

idgserpro commented 7 years ago

A test having a collection without query would be nice, but I don't know if it's worth the hassle. What do you think?

@makelli did you do exactly what @hvelarde said here (added if query is None: in your snippet) to solve your problem?

hvelarde commented 7 years ago

I'm not going to add that test, but feel free to do it ;-)

idgserpro commented 7 years ago

Just a brainstorm: we've seen too many packages pinning coverage as coverage = in it's buildouts. Do you think it's possible to handle this in https://github.com/collective/buildout.plonetest?

hvelarde commented 7 years ago

yes, but we need to pin a specific version; which one is used in Plone 5?

makelli commented 7 years ago

All configuration on plonegovbr release/1.1.5.2

On Thu, Jan 26, 2017 at 10:05 AM, Héctor Velarde notifications@github.com wrote:

yes, but we need to pin a specific version; which one is used in Plone 5?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/collective/collective.nitf/pull/187#issuecomment-275383619, or mute the thread https://github.com/notifications/unsubscribe-auth/AH_L2XoSC1C1M8Ohz8tJkCYTk11QOb-gks5rWJoggaJpZM4Lul6Y .

idgserpro commented 7 years ago

Your buildout extends https://raw.githubusercontent.com/collective/buildout.plonetest/master/test-4.3.x.cfg, which extends https://raw.githubusercontent.com/collective/buildout.plonetest/master/plone-4.3.x.cfg, which extends http://dist.plone.org/release/4.3-latest/versions.cfg, which extends http://dist.plone.org/versions/zope-2-13-24-versions.cfg which extends http://dist.plone.org/versions/zopetoolkit-1-0-8-ztk-versions.cfg that pins coverage to 3.5.2.

Your build broke because someone is asking for coverage > 3.7: it's createcoverage from https://github.com/collective/buildout.plonetest/blob/master/qa.cfg, since 1.4.1 it asks for coverage > 3.7.

In Plone 5, Plone overrides zope (which uses 3.5.2) to use 3.7.1 instead.

IMHO, we have three options:

Strange enough, Plone 5.1 uses 3.5.2 again. Don't know why.

idgserpro commented 7 years ago

Since it's the 1.x branch and not master, I think the test here is not worth the hassle, so it's merged.

hvelarde commented 7 years ago

I think the third option is the best one.

idgserpro commented 7 years ago

Me too.

Do you know how http://dist.plone.org/release/4.3-latest/versions.cfg is created? Who should we talk too, can @esteele help us?

hvelarde commented 7 years ago

I have no idea.

idgserpro commented 7 years ago

https://community.plone.org/t/how-http-dist-plone-org-release-4-3-latest-versions-cfg-is-generated/3357