collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Remove portlet used to show the latest news articles by section #197

Closed hvelarde closed 6 years ago

hvelarde commented 7 years ago

refs: https://community.plone.org/t/3569 refs. https://community.plone.org/t/6792

closes #132

hvelarde commented 7 years ago

@idgserpro as you can see this also solves a compatibility problem in Plone 5 by removing the dependency on the uid_catalog tool.

hvelarde commented 7 years ago

in my tests I noticed the portlet is broken and that reinforces my view that nobody can be using it.

hvelarde commented 7 years ago

@idgserpro I think is better to add a script on the 1.x version to remove the portlet and just remove the code in version 2.x adding a note in the migration guide; people moving from 1.x to 2.x should run that script prior to upgrade to 2.x.

do you agree?

hvelarde commented 6 years ago

@idgserpro acho que podemos mover isso para o branch 1.x.

idgserpro commented 6 years ago

I still think if you're removing a feature like this, you should change to 3.x. We can't know for sure if people aren't using this in the 2.x branch and 1.x is not being used that much after 2.x was launched.

Maybe in 2.x you should be hiding this portlet in the profile, or adding a Warning stating that in 3.x will be removed. If you get too much complaints after hiding it here in this package "why did you remove the portlet?" you know that you shouldn't be removing it, if not, well, since you're the maintainer of this project it's up to you to remove it or not.

hvelarde commented 6 years ago

as I mentioned before, nobody can be using this in 2.x because is just broken; so this is what I'm going to do:

I'l remove that in the near future.