search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Removal of "collective.nitf.controlpanel.INITFSettings.relatable_content_types" in upgradeStep missing #208

Closed idgserpro closed 7 years ago

idgserpro commented 7 years ago

The record was removed in https://github.com/collective/collective.nitf/commit/5a27baa54f728f1de123c6883e02020b481d7d00, but no upgradeStep to remove this record was added. Do you think it's needed or just having <records interface="collective.nitf.controlpanel.INITFSettings" remove="true" /> in uninstall is enough?

We're just concerned from an usability perspective, doign 1.x > 2.x and going to registry records in controlpanel and search for INITF's interface the value is still there.

selecao_024

hvelarde commented 7 years ago

we can remove it if it's no longer used.