wesleybl commented 2 years ago

The idea is drop support for Plone 4.3 and Plone 5.1. So these upgrades no longer make sense.

codecov-commenter commented 2 years ago

Codecov Report

Merging #243 (a4796ab) into master (28c6ad6) will increase coverage by 0.13%. The diff coverage is 98.42%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   96.22%   96.35%   +0.13%     
==========================================
  Files          40       33       -7     
  Lines        1799     1400     -399     
==========================================
- Hits         1731     1349     -382     
+ Misses         68       51      -17

Impacted Files	Coverage Δ
src/collective/nitf/browser/newsml.py	`44.44% <0.00%> (ø)`
...ollective/nitf/portlets/latest_sectionable_nitf.py	`86.66% <ø> (ø)`
src/collective/nitf/tests/api_hacks.py	`73.91% <0.00%> (ø)`
src/collective/nitf/tests/test_upgrades.py	`64.51% <75.00%> (-35.49%)`	:arrow_down:
src/collective/nitf/testing.py	`95.40% <96.00%> (ø)`
src/collective/nitf/__init__.py	`100.00% <100.00%> (ø)`
src/collective/nitf/behaviors/interfaces.py	`100.00% <100.00%> (ø)`
src/collective/nitf/browser/__init__.py	`100.00% <100.00%> (ø)`
src/collective/nitf/browser/nitf.py	`94.28% <100.00%> (ø)`
src/collective/nitf/browser/scaling.py	`86.11% <100.00%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c89bd8...a4796ab. Read the comment docs.

hvelarde commented 2 years ago

@wesleybl I think the changelog line must be more explicit for this kind of modifications: which upgrade steps where removed? what are the consequences of this removal? what problems could arise? what's the workaround?

wesleybl commented 2 years ago

I simply removed all upgrade steps. I bump version to 3.0.0: https://github.com/collective/collective.nitf/pull/244/commits/94c7ef916fa2e20f40312d0a5af564073ecf8e60

So the next release will be a major release. I think it's important to get rid of those old upgrade steps in major releases. The new release will only be for Plone 5.2 and most of these old upgrades don't make sense in Plone 5.2.

Release 3.0.0 will have to be installed on a 5.2 portal that has never had collective.nitf installed before. I recommend that migrations from Plone 4.3 to Plone 5.2 with Python 3 be done with collective.transmogrifier or collective.exportimport. This is because of the ZODB migration from Python 2 to Python 3, which I don't have much confidence that working without error. I can add the note in Changes to make this clear.

wesleybl commented 2 years ago

See: https://github.com/collective/collective.nitf/commit/6b004bd09e1188f522d756f0de632ff93b8197fb

collective / collective.nitf

Remove old upgrade steps #243

Codecov Report