search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Remove dependency on plone.app.imaging #245

Closed wesleybl closed 3 years ago

wesleybl commented 3 years ago

plone.app.imaging doesn't work with Python 3. See:

https://github.com/plone/plone.app.imaging/blob/297520aea1c315b99780697e0f053f3bec6323dd/setup.py#L27

Then we use plone.namedfile to scale the image.

codecov-commenter commented 3 years ago

Codecov Report

Merging #245 (1f16903) into master (5ee4620) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   82.03%   82.15%   +0.12%     
==========================================
  Files          31       31              
  Lines        1319     1300      -19     
==========================================
- Hits         1082     1068      -14     
+ Misses        237      232       -5
Impacted Files Coverage Δ
src/collective/nitf/browser/scaling.py 82.35% <100.00%> (+4.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ee4620...1f16903. Read the comment docs.