collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Register static resources in Resource Registry #248

Closed wesleybl closed 3 years ago

wesleybl commented 3 years ago

In Plone 5, it is not possible to register resources of external websites. See:

https://github.com/plone/Products.CMFPlone/issues/2387

So, in order to continue using Swiper by CDN, we cannot register it in the Resource Registry.

codecov-commenter commented 3 years ago

Codecov Report

Merging #248 (e24b7b5) into master (551276b) will increase coverage by 0.65%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   83.20%   83.85%   +0.65%     
==========================================
  Files          31       31              
  Lines        1298     1301       +3     
==========================================
+ Hits         1080     1091      +11     
+ Misses        218      210       -8     
Impacted Files Coverage Δ
src/collective/nitf/tests/test_setup.py 97.70% <100.00%> (+9.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 551276b...e24b7b5. Read the comment docs.