search

collective / collective.nitf

A Dexterity-based content type inspired on the News Industry Text Format specification
8 stars 3 forks source link

Fix Media View in Plone 5.2 #255

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

Use Plone Mockup to Modal.

Use Plone Mockup to sort media. With this it was possible to remove dependency on collective.js.jqueryui.

Also fixes robot tests of the view.

codecov-commenter commented 2 years ago

Codecov Report

Merging #255 (8d1649d) into master (fd5ef28) will increase coverage by 1.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   91.43%   92.68%   +1.25%     
==========================================
  Files          31       31              
  Lines        1296     1272      -24     
==========================================
- Hits         1185     1179       -6     
+ Misses        111       93      -18
Impacted Files Coverage Δ
src/collective/nitf/browser/__init__.py 100.00% <ø> (ø)
src/collective/nitf/tests/test_views.py 100.00% <ø> (ø)
src/collective/nitf/testing.py 94.36% <100.00%> (+27.69%) :arrow_up:
src/collective/nitf/tests/test_robot.py 100.00% <100.00%> (ø)
src/collective/nitf/tests/test_setup.py 98.75% <100.00%> (-1.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd5ef28...8d1649d. Read the comment docs.