search

collective / collective.recipe.omelette

https://pypi.org/project/collective.recipe.omelette/
4 stars 1 forks source link

setup.py uses 2to3 for Python 3 compatibility #10

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 4 years ago

I think this is the only Plone package that uses this. Added already in 2012, in commit b540f936354b0923dbd763fe160ba3817f720283. It may be better to this this differently, nowadays.

mauritsvanrees commented 4 years ago

When I create a source dist with python2.7 setup.py sdist and one with python 3.7, and compare the unpacked result, I actually see no difference.

With bdist, the internal structure is different, but that is because you have pythonX.7/site-packages. The code itself is the same.

I guess 2to3 can simply be removed. Using python-modernize may be good though. But no hurry.

mauritsvanrees commented 2 years ago

Fixed in release 1.1.0.