search

collective / collective.recipe.omelette

https://pypi.org/project/collective.recipe.omelette/
4 stars 1 forks source link

optimized unlinking of junctioned dirs on windows #2

Closed lck closed 12 years ago

lck commented 12 years ago

Hi, on my system it took 5 minutes to remove the entire dir. structure of buildout.coredev. With this patch it took 10 seconds. I tested this patch with latest plone buildout.coredev.

Regards Roman

davisagli commented 12 years ago

But won't this be a problem when there are namespace packages in the omelette? Namespaces are created as actual directories with symlinks inside those.

We could probably help by limiting the depth to which it recurses though.

lck commented 12 years ago

No, because the namespace directories are removed after the simlinks inside the directories are unlinked and removed.

lck commented 12 years ago

I tested this with plone/buildout.coredev and there are many namespace packages :)

davisagli commented 12 years ago

Oh, you're right. Okay, will merge this when I get a chance.

lck commented 12 years ago

Thanks!

davisagli commented 12 years ago

Released (v0.15). Thanks!