search

collective / collective.recipe.omelette

https://pypi.org/project/collective.recipe.omelette/
4 stars 1 forks source link

Added error handling #3

Closed loechel closed 12 years ago

loechel commented 12 years ago

Add error handling for the case that symlink fail. This could happen due to ignoring of namespace or package conventions in some packages. Example: Cython

do3cc commented 12 years ago

Could you catch the specific error being thrown and add the exception text to the log message?

loechel commented 12 years ago

Requested Traceback on runing collective.recipe.omelette without patch:

Installing omelette. While: Installing omelette.

An internal error occured due to a bug in either zc.buildout or in a recipe being used: Traceback (most recent call last): File "/usr/local/Plone/buildout-cache/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 1683, in main getattr(buildout, command)(args) File "/usr/local/Plone/buildout-cache/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 555, in install installed_files = self[part]._call(recipe.install) File "/usr/local/Plone/buildout-cache/eggs/zc.buildout-1.4.4-py2.7.egg/zc/buildout/buildout.py", line 1227, in _call return f() File "/usr/local/Plone/buildout-cache/eggs/collective.recipe.omelette-0.15-py2.7.egg/collective/recipe/omelette/init.py", line 162, in install symlink(package_location, link_location) OSError: [Errno 2] No such file or directory

snippet of logger warnig with patch applied:

Installing omelette. omelette: While processing egg Cython) symlink fails (/usr/local/Plone/buildout-cache/eggs/Cython-0.16-py2.7-linux-x86_64.egg/pyximport/init.py, /usr/local/Plone/diss.buildout/omelette-src/pyximport/init.py). Skipping. omelette: While processing egg Cython) symlink fails (/usr/local/Plone/buildout-cache/eggs/Cython-0.16-py2.7-linux-x86_64.egg/pyximport/pyxbuild.py, /usr/local/Plone/diss.buildout/omelette-src/pyximport/pyxbuild.py). Skipping. omelette: While processing egg Cython) symlink fails (/usr/local/Plone/buildout-cache/eggs/Cython-0.16-py2.7-linux-x86_64.egg/pyximport/pyximport.py, /usr/local/Plone/diss.buildout/omelette-src/pyximport/pyximport.py). Skipping.

I hope this info is enough.

Alexander

loechel commented 12 years ago

All request for changes in the pull-request discussed via irc with do3cc. added two commits: more specific error handling change of a typo

do3cc commented 12 years ago

Thanks for your contribution

davisagli commented 12 years ago

Please add a changelog entry for this change.