Closed saily closed 9 years ago
Will fix #32 as well.
I'am not deep enough into solr configuration and multi-core knowledge to fully get all implications, but this PR looks very clean, feels well thought and a is big step foreward, so +1 for merging it.
i rebased the whole branch onto master.
Hi, I did an review and some manual tests on this recipe. The changes look very clean as as @jensens already mentioned, but I found several issues that should be solved before merging and a release of an 6.0.0 version.
By the way, Plone did not work with generated schema as collective.solr.parser fails due to order of definitions in schema.xml
I did some fixings on the mentioned problems. Please review and check if that is consitent with intended cleanup (@saily).
Hi thanks for reviewing.
solr.cfg
of collective.solr
is another task which may follow this merge. Several things in that file did not work in past, for example solr-min-ram
and solr-max-ram
was never implemented. enablePositionIncrements
issue, thanks for that.synonyms.txt
file created out of a template. This was just copied over, which should work in the same behavior now. So implementing a new synonym.txt
template, target's a new feature which i did not want to implement through this pull, because we're changing a lot anyway.Ok, since we copy over all sample data shipped with solr now, the given schema.xml files should always work. There are some new locations (lang
folder) and naming conventions for stopwords.txt
but for now we should just ignore the new location and use the old one, people may have customized their templates.
This feature branch includes:
collection1
core) including it's templates, see #39logging.properties
.solr-location
is not set in recipe, this keeps legacy installations working fine.solr.EdgeNGramFilterFactory
)