search

collective / collective.recipe.solrinstance

Buildout recipe to configure a Solr instance
https://pypi.python.org/pypi/collective.recipe.solrinstance
5 stars 13 forks source link

[5.x] Fix schema and stop words template location #53

Closed gforcada closed 8 years ago

gforcada commented 8 years ago

Buildout first initializes a recipe, then installs it and even later updates it.

As solr configuration depends on downloading solr (done in a separate part with its own initialize, install and update), checking for a file to exist on the other (download) part does not work on the initial phase, but does on the install.

At the same time this recipe allows to override some templates, so if the template is not overriden, an empty string is used (on the init phase).

Thus on the install phase, a correct path can be built.

@tisto I went ahead and created the 5.x branch. This the fix I'm currently using to make 5.3.2 actually work.

gforcada commented 8 years ago

Finally fixed the errors. Anyone willing to merge? cc @tisto

tisto commented 8 years ago

@saily does that fix look ok to you? Would you have time to make a release? If you grant me pypi permissions (username: timo), I can make a release...

gforcada commented 8 years ago

@saily ping for the release :-) you could also grant plone user on pypi so the plone release team could make releases at any point as well

saily commented 8 years ago

@gforcada i've added you and plone. Sorry, but I can't do the release right now, can somebody else pick this up?

tisto commented 8 years ago

@gforcada do you plan to make a release then? I want to make another c.solr release in the next days anyways...

gforcada commented 8 years ago

@tisto you can do them if you wish, I already made an internal release for my needs

tisto commented 8 years ago

Done: https://pypi.python.org/pypi/collective.recipe.solrinstance/5.3.3

gforcada commented 8 years ago

@tisto thanks!