search

collective / collective.recipe.solrinstance

Buildout recipe to configure a Solr instance
https://pypi.python.org/pypi/collective.recipe.solrinstance
5 stars 13 forks source link

Deprecate the mc variant of this recipe #67

Closed ale-rt closed 3 years ago

ale-rt commented 3 years ago

Given that solr_version is always >= 4 there is no point in having this custom class: https://github.com/collective/collective.recipe.solrinstance/blob/822fd6b8de74144e660b48eae6128bc3bdc34855/collective/recipe/solrinstance/__init__.py#L819-L833

This is built on top of https://github.com/collective/collective.recipe.solrinstance/pull/66, which is already built on top of other PRs.

reinhardt commented 3 years ago

Just FTR, the wording “deprecate the mc variant” confused me a bit at first, but from the code it is clear that the multicore variant is becoming the only variant and explicitly specifying “mc" is being deprecated.