search

collective / collective.shibboleth

Shibboleth Embedded Discovery Service (EDS) support for Plone
1 stars 2 forks source link

Should collective.shibboleth be working with Plone 5? #1

Open ianzd opened 8 years ago

ianzd commented 8 years ago

I've only managed to get collective.shibboleth working with Plone 4. In Plone5, going to "Log in" gets me a browser modal that says "Error loading modal", and the attached error in instance.log

plone5-collective-shibboleth-error.txt

davidjb commented 8 years ago

I'm not currently using Plone 5 so haven't looked into how any components work with it. PR and fixes are most welcome!

tisto commented 6 years ago

Any update here? Anybody who tried to get c.shibboleth running with Plone 5?

@davidjb we could set up a Travis build for Plone 5 and check if build and tests work, what do you think?

davidjb commented 6 years ago

For sure; go right ahead. My focus is on other platforms than Plone at present but it would be good to ensure compatibility with Plone 5.

tisto commented 6 years ago

@davidjb seems we don't have a Travis setup for c.s yet: https://travis-ci.org/collective/collective.shibboleth

davidjb commented 6 years ago

It's not something I'd done previously, so please go right ahead. My focus is on other projects at the moment but if you need my input on something, let me know :)

davidjb commented 6 years ago

It's not something I'd done previously, so please go right ahead. My focus is on other projects at the moment but if you need my input on something, let me know :)

tisto commented 6 years ago

@davidjb I set up Travis for Plone 4.3, 5.0, and 5.1. I had to add a few missing test requirements and fix a wrong import on a test file. Though, we still have two test failures on the normal 4.3 tests:

https://travis-ci.org/collective/collective.shibboleth/jobs/439144358

Any idea where they come from?

tisto commented 6 years ago

@davidjb is it possible that those tests never actually passed? The test setup was using a collective.shibboleth.portlets package that does not exist. Anyways, I fixed the test setup and now all tests pass.

davidjb commented 6 years ago

Very possibly, @tisto. That package name sounds like it was prior to a refactoring that happened some time ago so I'd say yes, they probably never worked. Thanks for making all that work in that case!