search

collective / collective.solr

Solr search engine integration for Plone
https://pypi.org/project/collective.solr/
22 stars 46 forks source link

Plone 5.2.2 #269

Closed tisto closed 4 years ago

mauritsvanrees commented 4 years ago

@tisto Did you get a traceback without this? Or was the indexer not called anymore? Ah wait, this is not a plone.indexer but a base object.

Probably due to the changes in zope.interface. The interface class inheritance in the new version is more predictable and logical, but there can be small differences.

But yes, the original @implementer(ICheckIndexable) should have the same effect as the new provides="collective.solr.interfaces.ICheckIndexable", unless we are both confusing the meaning of implementer and provides.

tisto commented 4 years ago

@mauritsvanrees yes. I got a traceback without this complaining about a missing "provides" attribute. No idea why we the Python "@implementer" wasn't sufficient any longer. Though, I did not had time to further investigate...