search

collective / collective.solr

Solr search engine integration for Plone
https://pypi.org/project/collective.solr/
21 stars 46 forks source link

Allow using of environment variables for SolR config #311

Closed mpeeters closed 2 years ago

mpeeters commented 2 years ago

This is very helpful for Plone deployed with Docker.

This PR should be merged after #310

tisto commented 2 years ago

@mpeeters great addition! I merged #310, you need to rebase (if you create branches on the original repo, I can fix those things on my own, whatever you prefer...).

Could you briefly document those settings and especially what takes precedence in case of conflicts? We have three ways to configure c.solr settings now:

a) ENV vars b) ZCML c) registry / control panel

We should document all three options and make it clear what happens if you set multiple ones.

mpeeters commented 2 years ago

Your right @tisto I will update the documentation to explain how all those configuration methods works together.

tisto commented 2 years ago

@mpeeters good work and thanks for the swift response! Will merge and release now.