search

collective / collective.solr

Solr search engine integration for Plone
https://pypi.org/project/collective.solr/
21 stars 46 forks source link

Allow search accross multiple core #313

Closed mpeeters closed 2 years ago

mpeeters commented 2 years ago

This PR add a new parameter core for SolR search that can be used to search on other SolR core from the same SoLR server.

To allow a search from a new SolR core, a new named utility must be defined for ISolrConnectionManager with the core id as name.

tisto commented 2 years ago

@mpeeters just wondering: why don't you just use a virtual Solr core and handle this on Solr itself to keep things transparent for Plone?

tisto commented 2 years ago

@mpeeters jikes. I think I screwed up your PR with my latest changes in the main branch. Sorry for that. Can you look into rebasing?

mpeeters commented 2 years ago

@tisto the usecase is to allow search accross multiple SolR core that contains differents sets of data and may have different schemas because they are used by other Plone instances. This is the reason why this is limited to search.

tisto commented 2 years ago

@mpeeters I totally get the use case, because that's a common use case that we have as well. The thing I don't fully get is why you don't solve this with an individual "virtual" solr core that is used by a Plone instance. This way you don't need to add anything to collective.solr. The only possible downside of this Solr-only approach is that you need a (virtual) Solr core for each Plone instance you have.

tisto commented 2 years ago

@mpeeters somehow GHA are not triggered for this PR. Can you re-base to trigger a build?

mpeeters commented 2 years ago

@tisto I see your point, the problem here is that the client have more than 100 Plone websites that will search in only 3 shared Plone instances, duplicating core would involve huge infrastructure maintenance issues due to the large number of core to maintain. This is the main reason of this PR.

tisto commented 2 years ago

@mpeeters got it. I just wanted to understand your use case. Makes sense. Let's get GHA green on this PR and I can review, merge and release.

mpeeters commented 2 years ago

@tisto it seems that GHA does not run for PR where branches are from fork.

But you can check the status here : https://github.com/IMIO/collective.solr/actions?query=branch%3Amulticore++

laulaz commented 2 years ago

@tisto I've rebased the pull request. Could you please review & merge it before #319 ?

Thank you :pray:

mpeeters commented 2 years ago

Thanks @tisto