feat: add support of https connections

collective / collective.solr

Solr search engine integration for Plone

https://pypi.org/project/collective.solr/

21 stars 46 forks source link

feat: add support of https connections #367

Closed remdub closed 4 months ago

remdub commented 7 months ago

This PR adds support of https connections.

mpeeters commented 7 months ago

@remdub LGTM, add an entry in changelog

remdub commented 7 months ago

The implementation looks good to me, but I would expect the new config options to be mentioned in the documentation. https://collectivesolr.readthedocs.io/en/latest/usage/config.html

Done

mpeeters commented 7 months ago

Hello @tisto, can you please have look on this PR ?

bsuttor commented 5 months ago

I just rebase main to avoid conflicts, and LGTM

remdub commented 4 months ago

@remdub LGTM. Pls rebase. Then let's merge and release.

Thank you. I've solved conflicts, ready to squash and merge !