collective / collective.tocify

Integrates the Table of Contents pattern tocify (pat-tocify) with Plone
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Migrate patternslib pattern to pat-tocify #9

Open instification opened 9 years ago

instification commented 9 years ago

Migrate existing pattern to pat-tocify package.

http://patternslib.com/pattern-styleguide/#main-content

The styleguide is incomplete and needs expanding. It's on my TODO list and I'll try to get to it ASAP.

One easy way to check for minimal compatibility is to copy the .jshint file from Patterns repo and put that in your own and then do a check.

Another easy way to get the pattern to adhere to conventions is to use the Yeoman generator to generate the package layout (you can then copy your pattern into the src dir). https://www.npmjs.com/package/generator-patternslib

allcaps commented 8 years ago

@instification: Can you review: https://github.com/collective/pat-tocify ?

I used the latest: yo patternslib pat-tocify. As suggested by @thet via mail and available for all via https://www.npmjs.com/package/generator-patternslib

instification commented 8 years ago

@allcaps yes looking now. Annoyingly I already did this but didn't push it (was having the widget issue from #5 which you solved!!).

allcaps commented 8 years ago

Credits to Jens Klein who showed his jquery.ui folder loading during JS training. ;)

instification commented 8 years ago

@allcaps just built pat-tocify and still getting the widget issue ( #5 ) perhaps I should create a new issue in the pat-tocify repo?