search

collective / collective.transmogrifier

A configurable pipeline, aimed at transforming content for import and export
Other
5 stars 8 forks source link

Plone 5.2 and Python 3 support #22

Closed wesleybl closed 3 years ago

wesleybl commented 3 years ago

Guys, I tested this branch and it works in Python 3.

tisto commented 3 years ago

@wesleybl we are using c.transmogrifier with python3 for our migration. I think we have a fork and we might have to put some effort into. I will check with our team...

wesleybl commented 3 years ago

@tisto please have a look here too:

https://github.com/collective/collective.transmogrifier/pull/23

I think that before any step it would be good to have the CI working.

tisto commented 3 years ago

@wesleybl fully agree. PR merged.

wesleybl commented 3 years ago

@tisto I rebase it here and added tests for Plone 5.2. Work will still be needed to make it work in Python 2 and Python 3.

wesleybl commented 3 years ago

Tests are now passing in Python 2 Python 3 and Plone 5.2.

@tisto you have a look here please?

wesleybl commented 3 years ago

Can someone review here please?

@zopyx @cdw9 @rpatterson @tisto

wesleybl commented 3 years ago

@flipmcf I think I answered all your questions. Can you please approve the PR?

flipmcf commented 3 years ago

Pease excuse my tardiness.

Thank you for your work on this. It's appreciated.

wesleybl commented 3 years ago

Can someone please merge and make a new release?

@mauritsvanrees @hvelarde @tisto @lentinj