Closed wesleybl closed 3 years ago
I have edited the branch protection rules so you should be able to commit directly to master. And I have invited you to the project on PyPI. Please try it out. If it does not work, I can try.
Please try it out.
I will try. Thanks!
@mauritsvanrees I don't think I can commit to master yet. I tried to edit a file through the web interface and the message appears for me:
You can’t commit to master because it is a protected branch.
Not sure what is going there then, so I have released 2.0.0 to PyPI.
@mauritsvanrees Thank you very much!
Could you please give me permission on pypi also for the following packages:
I will need a release from them too. I can try to generate.
Of this, the only one I can't commit to master is plone.app.transmogrifier. I think it might be some branch protection rule in https://github.com/collective/plone.app.transmogrifier/settings/branches
In plone.app.transmogrifier
I removed the checkbox for "Restrict who can push to matching branches". Can you check if you can push now?
For collective.transmogrifier
this box is still checked, but I had given you explicit permission there, but that apparently was not enough.
On PyPI I have invited you as maintainer to collective.jsonmigrator and plone.formwidget.masterselect. I don't have access to the others.
@mauritsvanrees in plone.app.transmogrifier
i get the error:
$ git push
Counting objects: 3, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 357 bytes | 357.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least 1 approving review is required by reviewers with write access.
To github.com:collective/plone.app.transmogrifier.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:collective/plone.app.transmogrifier.git'
I think you have to add me in:
Restrict who can dismiss pull request reviews
I made changes to the package to work with Python 3 and Plone 5.2. I performed a migration from a portal to Plone 5.2 and Python 3.8.11 with the master branch and it worked correctly.
Could someone please create a 2.0.0 release? I don't have permission on the master.
@jensens @mauritsvanrees @tisto @lentinj