collective / collective.upgrade

11 stars 5 forks source link

Complete portal setup before migration #6

Closed gbastien closed 7 years ago

gbastien commented 7 years ago

Hi @rpatterson

this PR brings support for migrations using portal_skins or resources, different language than 'en' and when using BrowserLayer.

I added also the possibility to use a Zope user (admin) as user during migration.

Could you please review and merge?

Thank you!

Gauthier

rpatterson commented 7 years ago

I'm not maintaining this anymore, but I don't see any problems here after a cursory review. If anyone wants to step up and take over maintainership, speak up.

gbastien commented 7 years ago

Hi @rpatterson

we use it on various packages for now and we are about to migrate a 120 different clients application using it, we need it to work so we will still have a eye on it.

I add @bsuttor and @gotcha here to review my changes.

Thank you for your time.

Gauthier

gbastien commented 7 years ago

Hi @rpatterson

could you please give me pypi rights to do a release when this will be merged?

My pypi username is gauthierbastien

Thank you!

Gauthier

bsuttor commented 7 years ago

LGTM

rpatterson commented 7 years ago

Done.

On Wed, Mar 22, 2017 at 3:14 AM Gauthier Bastien notifications@github.com wrote:

Hi @rpatterson https://github.com/rpatterson

could you please give me pypi rights to do a release when this will be merged?

My pypi username is gauthierbastien

Thank you!

Gauthier

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/collective/collective.upgrade/pull/6#issuecomment-288354141, or mute the thread https://github.com/notifications/unsubscribe-auth/AANmAczFzCqakdlMfbybm3GA35e5WoZ6ks5roPSagaJpZM4MkAK1 .

gbastien commented 7 years ago

Great, thank you!

Gauthier