Open JeffersonBledsoe opened 1 year ago
Totals | |
---|---|
Change from base Build 7919988301: | 3.5% |
Covered Lines: | 727 |
Relevant Lines: | 780 |
While getting this up-to-date, I noticed we are now removing fields who's IDs don't exist on the form block definition (great!). This logic needs updating to account for custom_field_id being sent rather than the original field ID
@JeffersonBledsoe Add some tests please
@JeffersonBledsoe Add some tests please
Ah ok, exists already, just opened old version of this pr in some way :D
@JeffersonBledsoe Add some tests please
Ah ok, exists already, just opened old version of this pr in some way :D
Haha, thanks for checking! 😄 I look forward to the feedback!
This PR introduces the concept of a 'display value' to change how a value will appear in an email or on a form. For example, a 'Single choice' field could have submitted values of
['A', 'B', 'C']
, but are shown to the user as['Option A', 'Value B', 'Option C']
.Mostly tested in production with the 'Yes/ No widget' in volto-form-block, but should work for other fields too!
Requires https://github.com/collective/volto-form-block/pull/85 for frontend