search

collective / collective.volto.formsupport

Enable support for customizable forms in Volto
GNU General Public License v2.0
2 stars 8 forks source link

data cleaning script #41

Closed mamico closed 7 months ago

mamico commented 9 months ago

add a script that implements data cleansing (i.e. for GDPR purpose)

frontend: https://github.com/collective/volto-form-block/pull/77

JeffersonBledsoe commented 9 months ago

@mamico Just so I understand this right, users need to add a Field themselves to the block with an ID of remove_data_after_days for this to work? I like the idea. Could we split some of the functionality into a separate file so it could be re-used later? I can envision having a control panel to manage all form data across the site being really useful

mamico commented 9 months ago

@mamico Just so I understand this right, users need to add a Field themselves to the block with an ID of remove_data_after_days for this to work?

Yes. If I'm not mistaken this must be in the corresponding Volto package. Is this true?

Could we split some of the functionality into a separate file so it could be re-used later? I can envision having a control panel to manage all form data across the site being really useful

+1

erral commented 9 months ago

@mamico Just so I understand this right, users need to add a Field themselves to the block with an ID of remove_data_after_days for this to work? I like the idea. Could we split some of the functionality into a separate file so it could be re-used later? I can envision having a control panel to manage all form data across the site being really useful

I would definitely add this as a feature in the front-end. On the other hand, it's true that it requires a back-end job to be fully implemented.

So if added as a feature, it should be properly stated in the form that this requires a backend job to be present.

I don't know how to conjugate both requirements to let the end user clear that this must be set both in frontend and backend.

mamico commented 7 months ago

@erral @JeffersonBledsoe please take a look also here: https://github.com/collective/volto-form-block/pull/77

This is the main idea:

image

There is some work to finish, mostly related to UX, testing and documentation. Any suggestions or contributions will be appreciated :)

mamico commented 7 months ago

@JeffersonBledsoe @erral @cekk what about latest changes/commit ? I need the functionality for a customer request, afaik the only breaking change is the change of the method of the clean data service.

JeffersonBledsoe commented 7 months ago

Hi @mamico, I'm hoping to take a look at this in some more detail within a couple of weeks. If the only breaking change is the endpoint then I'm happy for this feature to get merged and we can iterate on any improvements we might think of down the road :)