search

collective / collective.volto.formsupport

Enable support for customizable forms in Volto
GNU General Public License v2.0
2 stars 8 forks source link

Resect email otp logics #56

Closed folix-01 closed 3 months ago

folix-01 commented 5 months ago

Logics moved here : https://github.com/collective/collective.volto.otp to be reusable

mamico commented 5 months ago

@folix-01 Is it possible to enable/disable this feature? Globally or specifically for each form?

folix-01 commented 5 months ago

@folix-01 Is it possible to enable/disable this feature? Globally or specifically for each form?

All this logics already working on master, the main target of this pr is to move the otp validation logics to another package.

As i remember the otp validation is inevitable if u have email in bcc fields, if we want to change this, it may be target of another pr

folix-01 commented 4 months ago

@sneridagh Can we merge this before we pass to the new setup ?

sneridagh commented 4 months ago

@folix-01 as long as @pnicolli and @mamico approve it and merge it, is fine, I will rebase. BTW, I didn't check this PR or what is for.

mamico commented 4 months ago

As depicted in the comments above, it appears that there are no real changes, but some code moved outside for future code reuse. It's ok for me.

I consider https://github.com/collective/collective.volto.formsupport/issues/57 important, but the issue was not started here.